Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.27] Once again revert "Adapt scheduler to work with dynamic derivations" #12576

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

Ericson2314
Copy link
Member

Motivation

The bug reappeared after all, and the fix introduced a different bug. We want to release 2.27 imminently so there is no time to do a proper fix, which appears to require a larger reworking. Hopefully we will have it for 2.28, however.

Context

This reverts commit c985252.


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

…ons"""

The bug reappeared after all, and the fix introduced a different bug. We
want to release 2.27 imminently so there is no time to do a proper fix,
which appears to require a larger reworking. Hopefully we will have it
for 2.28, however.

This reverts commit c985252.
@Ericson2314 Ericson2314 added this to the nix-2.27 milestone Feb 27, 2025
@github-actions github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Feb 27, 2025
@roberth roberth changed the title [2.27] Once again reevert "Adapt scheduler to work with dynamic derivations" [2.27] Once again revert "Adapt scheduler to work with dynamic derivations" Feb 27, 2025
Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a pretty clean revert.

@roberth roberth merged commit 863c1b6 into NixOS:2.27-maintenance Feb 27, 2025
13 checks passed
@Ericson2314 Ericson2314 deleted the 2.27-no-dyn-drv branch February 27, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
with-tests Issues related to testing. PRs with tests have some priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants